Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gather csv output column "filename" takes from first in list of databases #563

Closed
taylorreiter opened this issue Oct 29, 2018 · 2 comments
Closed

gather csv output column "filename" takes from first in list of databases #563

taylorreiter opened this issue Oct 29, 2018 · 2 comments
Labels
bug

Comments

@taylorreiter
Copy link
Contributor

I recently ran sourmash gather with 5 databases simultaneously. The output csv file indicated in the filename column that each of my matches were from the first database that I listed, however they were from different databases that I listed.
@ctb
Copy link
Contributor

ctb commented Nov 1, 2018

Yep. Bug.

This is a problem encoded in line 116, line 123, and line 131 of search.py - we need to append a 3-tuple containing (similarity, ss, filename) to results instead of the current 2-tuple.

@ctb ctb mentioned this issue Dec 27, 2018
Merged
5 tasks
@ctb
Copy link
Contributor

ctb commented Dec 27, 2018

Fixed in #589.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctb @taylorreiter