Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourmash sig manifest on zip files yields unusable standalone manifest CSVs #3009

Closed
ctb opened this issue Feb 17, 2024 · 2 comments · Fixed by #3027
Closed

sourmash sig manifest on zip files yields unusable standalone manifest CSVs #3009

ctb opened this issue Feb 17, 2024 · 2 comments · Fixed by #3027

Comments

@ctb
Copy link
Contributor

ctb commented Feb 17, 2024

The internal_location is kept as the internal location in the zipfile, rather than the name of the zipfile:

% sourmash sig manifest example.sig.zip -o mf.csv
...
% cat mf.csv | cut -c, -f1
# SOURMASH-MANIFEST-VERSION: 1.0
internal_location
signatures/324074c7287ed934af4fd0a6a459aa30.sig.gz
% sourmash sig describe mf.csv
...
ERROR: Error while reading signatures from 'signatures/324074c7287ed934af4fd0a6a459aa30.sig.gz'.
@ctb
Copy link
Contributor Author

ctb commented Feb 21, 2024

(it looks like sig collect is the right thing to use here, FWIW. will verify.)

@ctb
Copy link
Contributor Author

ctb commented Mar 5, 2024

Yes - verified in #3023, updating docs in #3027 which will close this issue.

@ctb ctb closed this as completed in cfe6a96 Mar 20, 2024
@ctb ctb closed this as completed in #3027 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant