Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thoughts on internal_location in manifests - should it be a URI? #2258

Open
ctb opened this issue Sep 5, 2022 · 0 comments
Open

thoughts on internal_location in manifests - should it be a URI? #2258

ctb opened this issue Sep 5, 2022 · 0 comments

Comments

@ctb
Copy link
Contributor

ctb commented Sep 5, 2022

from a slack conversation with @luizirber about meaning(s) of internal_location -

Luiz:

URLs in IPFS are /ipfs/<hash>, in any case the important thing is the
<hash>
fsspec uses this syntax:
ipfs://QmZ4tDuvesekSs4qM5ZBKpXiZGun7S2CYtEZRB3DYXkjGx
https://github.com/fsspec/ipfsspec#ipfsspec

Me:

I like that. Right now there are no limitations on
row['internal_location'] since it is meant to be internally interpreted by the
Index class using it. if we start going with URIs instead, that makes a lot of
sense to me.

dovetails with supporting file loading over HTTPS #2257, direct Index.get functionality using iloc (#1901 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb