Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider SourmashSignature downsample and flatten #2175

Open
ctb opened this issue Aug 3, 2022 · 0 comments
Open

consider SourmashSignature downsample and flatten #2175

ctb opened this issue Aug 3, 2022 · 0 comments

Comments

@ctb
Copy link
Contributor

ctb commented Aug 3, 2022

After #1610, it seems like an obvious next set of simplifications is to remove all of the with x.update(): ... code blocks and replace them with flatten and/or downsample calls.

The only thing that prevents me from doing that now is that I'm not sure the abstraction is at the right level. Do we want to be making detailed calls about what to do with MinHash-specific information like abundances and scaled values, or do we want to be asking for "compatible" sketches on SourmashSignature objects, ref #616?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant