Bump sourcegraph dependency to fix version parsing of insiders #959
Conversation
For untagged versions, we added the current Sourcegraph version as well, so the parsing didn't work anymore. This fixes it.
| @@ -113,7 +113,7 @@ BUCKET | |||
| progress := out.Progress(progressBars, nil) | |||
| progress.WriteLine(output.Emoji(output.EmojiHourglass, "Starting uploads...")) | |||
| bucket := c.Bucket(*bucketName) | |||
| g := group.New().WithErrors().WithContext(ctx) | |||
| g := pool.New().WithErrors().WithContext(ctx) | |||
There was a problem hiding this comment.
I had to, the lib/group package was deleted :lolsob: 😬
|
oh boi this is a big mess. conc requires go 1.19, but then golangci-lint fails because it doesn't understand 1.19 in that version, and when I upgrade it it starts complaining about new stuff - really annoying. |
|
@BolajiOlajide @Piszmog could I get a quick re-review on this, I had to do a bunch of changes to get it to compile with conc as a dependency. |
| @@ -67,9 +67,11 @@ func (e *fastCommandTimeoutError) Error() string { | |||
|
|
|||
| func (*fastCommandTimeoutError) Timeout() bool { return true } | |||
|
|
|||
| type fastCommandTimeoutKey string | |||
There was a problem hiding this comment.
Why do we need this type?
There was a problem hiding this comment.
golangci-lint reminded me that using a custom type the string is ensured to always be globally unique, if it's a plain string it might have clashes with other ctx keys - pretty interesting magic honestly
| @@ -185,6 +185,8 @@ func (svc *Service) uploadFile(ctx context.Context, workingDir, filePath, batchS | |||
| // Errors passed to pipeWriter.CloseWithError come through here. | |||
| return err | |||
| } | |||
| defer resp.Body.Close() | |||
There was a problem hiding this comment.
Thanks for catching.
There was a problem hiding this comment.
golangci-lint did, I know nothing 😆
For untagged versions, we added the current Sourcegraph version as well, so the parsing didn't work anymore. This fixes it.
For untagged versions, we added the current Sourcegraph version as well, so the parsing didn't work anymore. This fixes it.
Test plan
Verified the error no longer shows when targeting S2.