-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permissions-center: use new permissionSyncJobs
query.
#942
Conversation
Test plan: `src snapshot test` runs successfully and fetches perms sync information from a local sg instance.
internal/instancehealth/checks.go
Outdated
continue | ||
} | ||
syncCount += 1 | ||
if sync.Status == "ERROR" { | ||
syncErrors = append(syncErrors, sync.Message) | ||
if sync.State == "ERROR" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sync.State == "ERROR" || sync.State == "FAILURE"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was not the part of original logic, but I agree.
@bobheadxi ping, just in case :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, the FAILURE
state is new IIRC so let's include it :)
internal/instancehealth/checks.go
Outdated
if _, ok := seenProviders[key]; !ok { | ||
seenProviders[key] = make(map[string]string) | ||
} | ||
// Just track one message per state for reference | ||
seenProviders[key][p.Status] = p.Message | ||
out.WriteLine(output.Linef(output.EmojiInfo, output.StyleBold, "%s %s %s %s", p.ProviderID, p.ProviderType, p.Message, p.Status)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, leftover debug stuff, thanks for catching!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
Test plan: `src snapshot test` runs successfully and fetches perms sync information from a local sg instance.
Test plan:
src snapshot test
runs successfully and fetches perms sync information from a local sg instance.Follow-up to https://github.com/sourcegraph/sourcegraph/pull/47933