-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src validation for ebs-csi drivers and VPCs #939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great overall! I think it's going to be really helpful as well 🚀
6412338
to
eb6ddb1
Compare
- Before, validation ran regardless of whether current kubectl context was set to an EKS cluster or not - Now, if --eks flag is added to the command, src checks that an EKS cluster is already configured
6ec4c18
to
19ae11a
Compare
Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really nice! Just a few suggestions, otherwise LGTM 🚀
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
da274f5
to
af91e35
Compare
* validate ebs-csi drivers on EKS clusters * add condition for failed config * add validation for vpcs * Adds tests for validate VPC * formatting, add comment for EksVpc * fix formatting in kube test * add test for ebs-csi validation and refactor * formatting * remove commented out function signature * checks current context when using --eks flag - Before, validation ran regardless of whether current kubectl context was set to an EKS cluster or not - Now, if --eks flag is added to the command, src checks that an EKS cluster is already configured * formatting * fix ineffectual append that linter flagged * refactor * formatting * retab * Adds more robust testing for ebs csi drivers * remove test copies from kube_test * formatting * retab * add tests and refactor * improve naming conventions to be less confusing and more informative * Update internal/validate/kube/kube.go Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com> * retab * more retabbing * Update internal/validate/kube/eks.go Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com> * Moved/renamed Eks() function to eks file * formatting --------- Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr> Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com> Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
This commit adds
ebs-csi
drivers on AWS EKS clusters andTest plan
Shipped with test suite