Validate: add support for kubernetes deployment validation with src validate kube subcommand
#926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add pod validation * Add skeleton for service and connection validation
jdpleiness
requested review from
eseliger,
abeatrix,
beyang,
DaedalusG,
jasonhawkharris and
jac
eseliger
approved these changes
Jan 20, 2023
beyang
reviewed
Jan 23, 2023
internal/validate/kube/kube.go
Outdated
|
|
||
| var results []validate.Result | ||
|
|
||
| //TODO make concurrent |
There was a problem hiding this comment.
Remove TODO in master branch
Suggested change
| //TODO make concurrent |
beyang
reviewed
Jan 23, 2023
internal/validate/kube/kube.go
Outdated
|
|
||
| var results []validate.Result | ||
|
|
||
| //TODO make concurrent |
There was a problem hiding this comment.
Suggested change
| //TODO make concurrent |
beyang
reviewed
Jan 23, 2023
internal/validate/kube/kube.go
Outdated
|
|
||
| var results []validate.Result | ||
|
|
||
| //TODO make concurrent |
There was a problem hiding this comment.
Suggested change
| //TODO make concurrent |
beyang
approved these changes
Jan 23, 2023
2 tasks
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
…validate kube` subcommand (#926) * Refactor out shared vars * Add basic kube validation * Add pod validation * Add skeleton for service and connection validation * Add connection validations * Add go modules files * Fix --kubeconfig flag * Fix line output * Add usage output to cli * Fix path in example * Add quiet flag to suppress output and return exit status only * Fix exit status to be consistent if there are failures * Remove TODOs * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
src validate kubesubcommand for validating Sourcegraph deployments on Kubernetes.Features include:
Validations can also include warnings for non-failure states that should be addressed.
Kubernetes cluster configuration is handled via standard kubeconfig file in users home directory or can be specified with
--kubeconfigflag. Users can also specify a specific namespace via--namespaceflag.TODO:
--quietflag to silence command line output in CI/CD pipelinesTest plan
internal/validate/kube/kube_test.go.