Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix src batch repo file parameter parsing #919

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Fix src batch repo file parameter parsing #919

merged 2 commits into from
Jan 12, 2023

Conversation

eseliger
Copy link
Member

Closes #914

Test plan

Verified the issue is resolved.

@eseliger eseliger requested a review from a team January 12, 2023 00:02
courier-new
courier-new approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@courier-new courier-new left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY thanks for just doing this. I was hoping it would be as simple 😄

CHANGELOG.md Outdated Show resolved Hide resolved
@eseliger @courier-new
Update CHANGELOG.md
80830c9 
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
@eseliger eseliger merged commit 6d72b3f into main Jan 12, 2023
@eseliger eseliger deleted the es/fix-batch-spec-param-parsing branch January 12, 2023 14:40
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@eseliger
Fix src batch repo file parameter parsing (#919)
de8f6e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courier-new courier-new courier-new approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

batches: piping of spec file fails for src batch repos without -f
2 participants
@eseliger @courier-new