Return an error when additional headers conflicts #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
SRC_ADDITIONAL_HEADERS_AUTHORIZATION=...
andSRC_ACCESS_TOKEN
at the same time leads to the latter overriding the former silently, making it quite difficult to spot.This PR surfaces the conflict as an error explictly advising to never set
SRC_ACCESS_TOKEN
in conjunction with the additional header.Test plan
Unit test + local run: