batches: improve handling of non-root steps #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default for `src batch exec` (used by SSBC) to run all step containers as root, and adds a flag to `src batch apply` and `src batch preview` to optionally do the same thing. Fixes #41836.
eseliger
approved these changes
Nov 18, 2022
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This changes the default for `src batch exec` (used by SSBC) to run all step containers as root, and adds a flag to `src batch apply` and `src batch preview` to optionally do the same thing. Fixes sourcegraph/sourcegraph#41836.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default for
src batch exec(used by SSBC) to run all step containers as root, and adds a flag tosrc batch applyandsrc batch previewto optionally do the same thing.Fixes sourcegraph/sourcegraph#41836.
Test plan
Tested with client and server side batch changes and a batch spec that outputs
idinto a file, with a container image that does not run as root by default (specifically,haproxy:alpine).