Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test advise package and more tests for kube package #1000

Merged
merged 2 commits into from
Jun 16, 2023
Merged

test advise package and more tests for kube package #1000

merged 2 commits into from
Jun 16, 2023

Conversation

jasonhawkharris
Copy link
Contributor

Adds more tests for the kube package and creates test file for advise package

Test plan

This commit is only tests.

jdpleiness
jdpleiness approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@jdpleiness jdpleiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

internal/scout/advise/k8s.go Show resolved Hide resolved
@jasonhawkharris jasonhawkharris merged commit 25f9e0f into main Jun 16, 2023
@jasonhawkharris jasonhawkharris deleted the jhh/more-tests branch June 16, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpleiness jdpleiness jdpleiness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonhawkharris @jdpleiness