schema: Specify the encoding for character offsets #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
PositionEncoding
field so that indexers can specifywhat type of character offsets they are using. This way, consumers of SCIP
can unambiguously interpret the offsets for non-ASCII data.
I have kept it as a field on
Document
rather thanIndex
because:Index
becauseoccurrences only belong inside Documents, not outside.
which use different kinds of offsets.
Test plan
n/a