Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go bindings: Remove occurrences with empty ranges during canonicalization #180

Merged
merged 3 commits into from
Jun 27, 2023
Merged

go bindings: Remove occurrences with empty ranges during canonicalization #180

merged 3 commits into from
Jun 27, 2023

Conversation

efritz
Copy link
Contributor

@efritz efritz commented Jun 27, 2023

slack context with sentry error

Test plan

  • Write unit tests for canonicalization

@efritz efritz requested a review from varungandhi-src June 27, 2023 14:40
@efritz efritz self-assigned this Jun 27, 2023
@efritz efritz requested a review from varungandhi-src June 27, 2023 14:46
@varungandhi-src
Copy link
Contributor

CI is failing to download node...? Wut?

Downloading node-v16.7.0-linux-x64.tar.gz...
-> https://nodejs.org/dist/v16.7.0/node-v16.7.0-linux-x64.tar.gz
error: failed to download node-v16.7.0-linux-x64.tar.gz
-> https://nodejs.org/dist/v16.7.0/node-v16.7.0-linux-x64.tar.gz
error: failed to download node-v16.7.0-linux-x64.tar.gz

@keynmol
Copy link
Contributor

keynmol commented Jun 27, 2023

I re-ran the job, seems like a weird networking issue on GHA

@efritz efritz merged commit 45df7f6 into main Jun 27, 2023
@efritz efritz deleted the ef/bad-range branch June 27, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varungandhi-src varungandhi-src varungandhi-src approved these changes

Assignees

@efritz efritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efritz @varungandhi-src @keynmol