bindings/go: Fix bug with incomplete reads #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
changed the title
|
Did this go test failure just start happening? or was this from before? |
|
That failure is entirely unrelated to this PR AFAICT, not sure why it's coming up but will look into it tomorrow before merging. |
Using Reader.read doesn't guarantee that the buffer passed will be filled if enough data is available, and the buffer has enough space. This meant that sometimes an initial Read call would not suffice for large Document data. Use ReadAtLeast to avoid that.
varungandhi-src
force-pushed
the
vg/fix-read
branch
from
15d4bdc to
5ce20e1
Compare
|
Perhaps an artifact of targeting a branch other than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Added regression test