Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go bindings: Don't panic on half-finished descriptors #171

Merged
merged 1 commit into from
Jun 13, 2023
Merged

go bindings: Don't panic on half-finished descriptors #171

merged 1 commit into from
Jun 13, 2023

Conversation

efritz
Copy link
Contributor

@efritz efritz commented Jun 13, 2023

Test plan

It doesn't crash now :clueless:

@efritz efritz requested review from tjdevries and cesrjimenez June 13, 2023 19:33
@efritz efritz force-pushed the ef/harden-parser branch from 7305420 to b8e0d8a Compare June 13, 2023 19:40
tjdevries
tjdevries approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@tjdevries tjdevries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me. think we just missed the error there

@efritz efritz merged commit b627338 into main Jun 13, 2023
@efritz efritz deleted the ef/harden-parser branch June 13, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesrjimenez cesrjimenez cesrjimenez approved these changes

@tjdevries tjdevries tjdevries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efritz @tjdevries @cesrjimenez