Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enclosing_range to Occurrence message #150

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

efritz
Copy link
Contributor

@efritz efritz commented May 2, 2023

This PR adds a field to Occurrence which we plan to populate as a by-product of symbol generation or highlighting. We will consume this almost immediately in the Cody context APIs to break off only the relevant portion of a code intelligence result. This will also allow us to generate more intelligent embeddings chunks. This can also help us determine call hierarchies as we now have a way to extract symbols within the implementation of a given symbol (by range).

Test plan

N/A

@efritz efritz self-assigned this May 2, 2023
@efritz efritz requested a review from olafurpg May 2, 2023 21:55
scip.proto Outdated Show resolved Hide resolved
scip.proto Outdated Show resolved Hide resolved
scip.proto Outdated Show resolved Hide resolved
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to push a commit that addresses my comments. LGTM 👍🏻

@olafurpg
Copy link
Member

olafurpg commented May 3, 2023

A good followup PR would be to add enclosing_range to the snapshot output so that we can more easily test it. It's not a blocking issue since we will most likely need to rewrite the snapshot format in Rust for syntax-highlighter.

@efritz efritz merged commit ee677ba into main May 3, 2023
@efritz efritz deleted the ef/enclosing_range branch May 3, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants