Add NO_PROXY test that ensures dot prefixes are considered a wildcard #6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
commented
Jan 8, 2025
Comment on lines
153
to
+156
| // They shouldn't use the same agent | ||
| expect(noProxiedAgent).not.toBe(wildcardNoProxyAgent) | ||
| expect(noProxiedAgent).not.toBe(dotNoProxyAgent) | ||
| expect(wildcardNoProxyAgent).not.toBe(dotNoProxyAgent) |
There was a problem hiding this comment.
I'm not sure what the significance of this test is, I just cargo-culted it. Maybe it's possible for agent.connect to cache & return the same agent, so we want to make sure each proxy configuration returns a different agent?
There was a problem hiding this comment.
Ah yes, describe('DelegatingAgent caching')
qaisjp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying
.example.cominstead of*.example.comis a valid way of specifying a wildcard, but this is not currently tested byDelegatingAgent.Test plan
Changelog