Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onebox): Use new prompt editor when onebox is enabled #6288

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

fkling
Copy link
Contributor

@fkling fkling commented Dec 9, 2024

This updates HumanMessageEditor to use the new prompt editor when onebox is enabled.

Test plan

Tested locally by enabling the feature flag for myself on S2.

@fkling
Copy link
Contributor Author

fkling commented Dec 9, 2024

This change is part of the following stack:

Change managed by git-spice.

@fkling fkling force-pushed the fkling/prompt-editor branch from 0768e58 to 28a42d3 Compare December 16, 2024 14:03
@fkling fkling force-pushed the feat-onebox-use-new-prompt branch from 4165cac to 57fb41c Compare December 20, 2024 13:04
@fkling
Copy link
Contributor Author

fkling commented Dec 20, 2024

@thenamankumar I've updated the PR to use a new/separate feature flag. I don't know if anything else needs to be done when adding a new feature flag.

@fkling fkling force-pushed the fkling/prompt-editor branch 2 times, most recently from 806b534 to 17a9c08 Compare December 21, 2024 12:57
@fkling fkling force-pushed the feat-onebox-use-new-prompt branch from 57fb41c to 6f2dab8 Compare December 21, 2024 12:57
Base automatically changed from fkling/prompt-editor to main December 21, 2024 13:09
@fkling fkling force-pushed the feat-onebox-use-new-prompt branch from 6f2dab8 to 459e618 Compare December 21, 2024 13:09
@fkling fkling merged commit b1dbde1 into main Dec 21, 2024
19 of 21 checks passed
@fkling fkling deleted the feat-onebox-use-new-prompt branch December 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants