fix(tenant-management): resolve sonar issues

resolve sonar issues GH-47
sourcefuse · Oct 11, 2024 · 29c1f8c · 29c1f8c
1 parent c68c044
commit 29c1f8c
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 13 deletions.
diff --git a/services/tenant-management-service/src/controllers/idp.controller.ts b/services/tenant-management-service/src/controllers/idp.controller.ts
@@ -49,17 +49,20 @@ export class IdpController {
     })
     payload: IdpDetailsDTO,
   ): Promise<IdpResp> {
-    let res: IdpResp = {
+    const res: IdpResp = {
       authId: '',
     };
     switch (payload.tenant.identityProvider) {
       case IdPKey.AUTH0:
-        let auth0Resp = await this.idpAuth0Provider(payload);
+        // eslint-disable-next-line
+        const auth0Resp = await this.idpAuth0Provider(payload);
         return auth0Resp;
+
       case IdPKey.COGNITO:
         break;
       case IdPKey.KEYCLOAK:
-        let keycloakResp = await this.idpKeycloakProvider(payload);
+        // eslint-disable-next-line
+        const keycloakResp = await this.idpKeycloakProvider(payload);
         return keycloakResp;
 
       default:

diff --git a/services/tenant-management-service/src/models/dtos/subscription-dto.model.ts b/services/tenant-management-service/src/models/dtos/subscription-dto.model.ts
@@ -44,7 +44,7 @@ export class SubscriptionDTO implements ISubscription {
 
   @property({type: 'string'})
   invoiceId: string;
-  
+
   // Assuming IPlan interface is defined, you can include it here
   @property()
   plan?: IPlan;

diff --git a/services/tenant-management-service/src/providers/idp/idp-auth0.provider.ts b/services/tenant-management-service/src/providers/idp/idp-auth0.provider.ts
@@ -2,7 +2,7 @@ import {Provider} from '@loopback/context';
 
 import {ConfigureIdpFunc, IdpDetails, IdPKey, IdpResp} from '../../types';
 import {ManagementClient, PostOrganizationsRequest, UserCreate} from 'auth0';
-import { randomBytes } from 'crypto';
+import {randomBytes} from 'crypto';
 import {repository} from '@loopback/repository';
 
 import {HttpErrors} from '@loopback/rest';
@@ -57,19 +57,20 @@ export class Auth0IdpProvider implements Provider<ConfigureIdpFunc<IdpResp>> {
       enabled_connections: configValue.enabled_connections,
     };
     function generateStrongPassword(length: number): string {
-      const charset = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*()_+~`|}{[]:;?><,./-=';
-
+      const charset =
+        'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*()_+~`|}{[]:;?><,./-=';
+
       // Generate random bytes
       const randomBytesArray = randomBytes(length);
-      
+
       // Map each byte to a character in the charset
       const password = Array.from(randomBytesArray)
         .map(byte => charset[byte % charset.length])
         .join('');
-      
+
       return password;
     }
-  
+
     const passwordLength = 16;
     const password = generateStrongPassword(passwordLength);
     const userData: UserCreate = {

diff --git a/services/tenant-management-service/src/providers/idp/idp-keycloak.provider.ts b/services/tenant-management-service/src/providers/idp/idp-keycloak.provider.ts
@@ -14,7 +14,9 @@ interface Credentials {
   temporary: boolean;
 }
 
-export class KeycloakIdpProvider implements Provider<ConfigureIdpFunc<IdpResp>> {
+export class KeycloakIdpProvider
+  implements Provider<ConfigureIdpFunc<IdpResp>>
+{
   constructor() {}
 
   value(): ConfigureIdpFunc<IdpResp> {
@@ -42,8 +44,8 @@ export class KeycloakIdpProvider implements Provider<ConfigureIdpFunc<IdpResp>>
       );
     }
     return {
-      authId:"",          // dummy authID
-    }
+      authId: '', // dummy authID
+    };
   }
 
   async authenticateAdmin(): Promise<string> {