[CS-5844] fix implementation

sourcefabric · Jan 14, 2016 · 7708dc9 · 7708dc9
1 parent bc9b61c
commit 7708dc9
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/newscoop/library/Newscoop/Entity/Article.php b/newscoop/library/Newscoop/Entity/Article.php
@@ -1825,4 +1825,14 @@ public function setSectionId($sectionId)
 
         return $this;
     }
+
+    /**
+     * Get comments count
+     *
+     * @return integer
+     */
+    public function getCommentsCount()
+    {
+        return $this->comments_count;
+    }
 }
diff --git a/newscoop/src/Newscoop/NewscoopBundle/Controller/BackendPublicationsController.php b/newscoop/src/Newscoop/NewscoopBundle/Controller/BackendPublicationsController.php
@@ -82,8 +82,8 @@ public function editAction(Request $request, Publication $publication)
         }
 
         $publicationIssuesLanguages = array();
-        if (is_array($publication->getIssues())) {
-            foreach ($publication->getIssues() as $key => $issue) {
+        if ($publication->getIssues()->count() > 0) {
+            foreach ($publication->getIssues() as $issue) {
                 if (!in_array($issue->getLanguageCode(), $publicationIssuesLanguages)) {
                     $publicationIssuesLanguages[] = $issue->getLanguageCode();
                 }
@@ -191,7 +191,7 @@ private function processRequest($request, $form, $publication = null)
             }
 
             $publicationIssuesLanguages = array();
-            if (is_array($publication->getIssues())) {
+            if ($publication->getIssues()->count() > 0) {
                 foreach ($publication->getIssues() as $key => $issue) {
                     if (!array_key_exists($issue->getLanguageCode(), $publicationIssuesLanguages)) {
                         $publicationIssuesLanguages[$issue->getLanguageCode()] = $issue->getLanguage();

diff --git a/newscoop/src/Newscoop/NewscoopBundle/Controller/PluginsController.php b/newscoop/src/Newscoop/NewscoopBundle/Controller/PluginsController.php
@@ -76,7 +76,7 @@ public function indexAction(Request $request)
             }
         }
 
-        // check if private plugins is writable 
+        // check if private plugins is writable
         $privatePluginsPathWritable = is_writable($pluginService->getPluginsDir().self::PRIVATE_PLUGINS_DIR);
 
         // search for private plugins

diff --git a/newscoop/src/Newscoop/NewscoopBundle/EventListener/OldPluginsTranslationListener.php b/newscoop/src/Newscoop/NewscoopBundle/EventListener/OldPluginsTranslationListener.php
@@ -9,7 +9,7 @@
 
 use Symfony\Component\HttpKernel\Event\GetResponseEvent;
 use Symfony\Component\Finder\Finder;
-use Symfony\Component\Translation\Translator;
+use Symfony\Component\Translation\TranslatorInterface as Translator;
 use Symfony\Component\Translation\Loader\YamlFileLoader;
 
 /**