-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Powerline symbols are incorrect #33
Comments
Thank you! I have been looking for feedback from Powerline users. @corelon and I worked on the Powerline glyph alignment and it seemed to have proper vertical alignment on OS X but we haven't looked into this on other OS. Can you let me know what platform you are on? |
Looks like the sidebearings (horizontal alignment) are a bit off in your images as well... |
Thanks @amfl . queued up! |
Here is the alignment of the Powerline glyphs in Hack (with 'Ac1' added for comparison): For the horizontal positioning issues: For the vertical positioning issues: I think that this will be a bit of trial and error... |
I'd be more than happy to help out here. It looks like my system, for some reason, has padding around the top and bottom of the text to make the color equal on both sides. You can see this in people's screenshots. Their text is closer to the bottom of the boxes than the top. Where is everyone using powerline? What shell / terminal application? I'm using this repo (https://github.com/jeremyFreeAgent/oh-my-zsh-powerline-theme) at Edit: I just pulled my theme down to the version available on master with no change. |
I am experiencing the same problem stated above. I use termite for my terminal emulation on manjaro linux. |
I'd love to help out with testing this issue and any fixes you may have. Here is Hack at 14px on the Terminal.app OSX 10.10.4 on a Retina display: And here it is on the same system but this time in iTerm2: Unfortunately, you can see that they treating the vertical positioning differently. If you need any other screenshots, different font sizes, more zoomed in, screenshots with an on screen rule or anything else I am more than happy to do that. |
First iteration of the Powerline glyph alignment changes (PL1). Replace the Hack regular set with this one and continue to use the name 'Hack' to define the font. PositionsBranch arrow (U+E0A0)
LN glyph (U+E0A1)
R solid arrow head (U+E0B0)
R narrow stroke arrow head (U+E0B1)
L solid arrow head (U+E0B2)
L narrow stroke arrow head (U+E0B3)
|
@shosca getting close vertically. The glyph sizes are too small on your system. It looks like the arrowheads need to be larger. Let's see a few more examples and we can try again. |
I came here to file this same issue report. I am an Arch Linux user currently using Liberation Mono for Powerline. In that font and many others that I patched using the available font patch tools, the powerline arrow glyphs are always 100% of the line height. I don't understand why this should be a matter of trial and error and adjusting. Running the font patcher does a bunch of math on the existing font metrics to find the proper height and width for these glyphs. Can you not backport those metrics into the base font files? |
Here is Terminal.app top and iTerm2 bottom. OSX 10.10.4. Font size 14px: And again here at font size 48px. Not something most people would ever use but iTerm2 is acting very strange and I thought maybe this "zoomed" in view might help with debugging. Let me know if this is helpful and I'll remember to always do this in future. Font size 48px; |
@alerque Are you referring to the official script released on the Powerline repository? I looked into this a few months ago and my recollection is that I came across an issue report thread that pushed me to avoid the script. My sense was that this script is no longer in general use because it failed to appropriately import the glyphs in attempts by a number of others. Am I mistaken? Can you provide more detail on the metrics that it provides? My goal is to adjust the Powerline glyphs to the Hack metrics and maintain them in the general release rather than generate a separate patched build. |
@Binarytales what do you mean by 'strange'? |
Test build 2 is available (PL2) with changes in the horizontal spacing of the solid arrowheads and increase in size of the solid arrowheads. Let me know what you think. Thanks for all of the screenshots. These have been very helpful. Download Link |
Just want to chime in and say that the fonts in the pull request also lines up correctly on my setup archlinux, urxvt(v9.22), vim (v7.4 p1689) |
my setup (same as up above earlier): ubuntu 14.04 / fish shell / fisherman / agnostertheme / font size 12 |
I submitted versions to them initially and it took a great deal of time for the PR’s to be accepted so I stopped. This isn’t a criticism, I understand this well. It just wasn’t serving our release schedule. I think it is useful to include them there. Many find that site when they are looking for new fonts with Powerline glyphs and I would like to maintain our sets as part of their releases even if older versions of the fonts. |
@iirelu Thank you Anna! @stefan-kern Thank you Stefan! It sounds like we may have an approach for Linux/FreeType. Have either of you modified your default font-config settings on your platforms? |
@chrissimpkins Ok, I get it. Sorry if it looks like I by-passed you, that's really not my goal ;) |
@Anthony25 Absolutely no problem at all. That decision is up to the Powerline developers and the community of users. It's not mine to make. |
I'll test this at work today with iTerm2 on OSX :) fingers crossed |
None are perfectly aligned but they're only off by a minor amount, barely noticeable from a distance on a retina screen. 12pt prior to @Anthony25 PR: 12pt fix I did with GlyphsApp: My fix for the 12pt only works on 12pt(I don't know font design well enough to know if there is a way to fix that), it was done through many manual tweaks until it looked right. At other sizes it breaks similar to original and PR. I'm using a zsh theme called Powerline9k, not the python Powerline lib. I don't think the methods to render the glyphs would be too different, but there is a slight chance it's not the same. |
Could it be because I didn't patch the fonts with font-line? I mean I took the ttf of your last release, but the glyphs replaced by the Powerline script are not, are they? Edit: my question wasn't clear. I meant: do the glyphs replaced by powerline need to be patched with font-line? |
@polarathene Thanks for posting these Brennan. The new patched version looks good on OS X. Would the shapes/metrics in the patched version be acceptable based upon your view on the screen c/w the patch that you implemented? |
No not at all. font-line modifies the default line spacing in the font. It is not a patching tool. We have discussed a tool that will patch new glyphs into the font but it hasn't been developed yet. As I understand the Powerline font patching script, there is a comparison of the metrics in the target font and the released Powerline glyph set. The Powerline glyphs are appropriately scaled and merged into the target fonts. There should not be any line spacing adjustments with that script and that is both intentional and a good thing. |
@chrissimpkins Just saw these pictures at home on my non retina screen(external laptop screen on linux). They appear blurry and you cannot clearly see the differences too well(Clicking them for fullsize helps). On OSX I'm sure the PR patch is fine :) Not as many users would be as nitpicky as I am with the tiny (couple of pixels) vertical offsets. 14pt is really the only one that would bother me(right prompt specifically, left prompt looks fine). That may just be due to kerning(I think that is the term), similar to other cases where instead of pushed to the right it was pushed to the left causing a gap. I can always send over my modified version for 12pt if it'd be of any help. |
@polarathene Thanks Brennan. I think that we are good with these comments. I really appreciate your feedback. |
Anyone else in the thread have comments on how the patched version looks in their Powerline or Powerline variant? |
System : Archlinux I xrdb .Xresources and updated font cache |
On the issue of symbols appearing as too short (Linux): in my case it turned out that my high-density screen on a newer laptop was causing fonts not to display properly, as fontconfig appears to not pick up DPI correctly from the X server. Putting this in
Replace the |
My pull request has finally been merged into powerline-fonts: powerline/fonts#172 It should fix the weird rendering. Edit: well, not entirely fix it, according to @polarathene screenshots, but it largely improves it on <=1080p displays. |
PR in #234 that is aimed at Linux and Win Powerline glyph users. Would greatly appreciate your feedback on the test font files there to confirm that there is an improvement in rendering that addresses these issues on those platforms and doesn't create significant new issues on those or OS X. Thanks! |
I tested the HackTest4 attachment from PR #234 and it has fixed the issue for me entirely -- both with the agnoster theme in zsh and the powerline (airline, really) in vim. My system: .Xresources file:
Please let me know if I can provide any other relevant information. Thanks for this font, too. I'm a big fan of it. |
👍 👍 👍 @rage311 thank you! This PR will be merged in the v3.0 release. cc: @iamjamestl see #33 (comment)
Our pleasure! |
We are planning to merge the changes from @iamjamestl in #234 as part of an upcoming release. Once he has rebased his modified glyph source on our new source code (part of the v3.0 release transition) I will build files with our new build tool chain and notify all here so that you can give them a try. @iamjamestl has performed a great deal of testing on Linux. It would be very helpful to have feedback from OS X and Windows users of Powerline/Powerline style terminal UI's that use these glyphs as we prepare for the release. Will notify here when they are available for anyone who is willing to help with testing. Thanks in advance! And thanks to @iamjametl for the extremely detailed attempt in #234 to fix these problematic glyphs! The images that he posted there look fantastic. Hope these changes work for all. |
New development build files with @iamjamestl Powerline glyph changes are now available in the Desktop files are available on the path The current build files are labeled These changes should significantly improve rendering of Powerline glyphs on Linux and Windows platforms. Please let us know if you have any problems. These changes will be released as part of our upcoming version 3.0 release. |
These changes to the Powerline separator glyphs is the result of studying the ones from DejaVu Sans Mono and Fantasque Sans Mono which appear seamless, without gaps or points extending above and below the line. We make the outlines slightly larger than the bounding box to cause the renderer to overlap the character with the surrounding ones, eliminating the gaps. Experimentation with different sizes and shapes was performed in source-foundry#234 under several renderers and applications to try to get the most consistency across platforms. Closes source-foundry#33
Under Hack:
Under a font with proper powerline symbols (in this case Fantasque Sans):
Note how Hack's symbols don't properly fill the entire height of the character, whilst Fantasque's ones do.
The text was updated successfully, but these errors were encountered: