Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some useless ACQ star warnings #437

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Remove some useless ACQ star warnings #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca4812d
Remove some useless ACQ star warnings
jeanconn Nov 28, 2023
87a6e22
Remove Acq star implication of ACA-041
jeanconn Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions starcheck/src/aca_load_review_cl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,7 @@ Checks
|ACA-040|Monitor commanding|X|X|Dither is disabled and enabled with correct|n/a |Failure to track|
| | | | |timing | | |
+-------+------------------+-+-+-------------------------------------------+----+----------------+
| | |X|X| | |AS: Reduced |
| | | | | | |acq probability |
| | | | | | |of star |
|ACA-041|Magnitude | | |Slot MAXMAG (faint limit) - star MAG >= 0.3|n/a |GS: Increased |
|ACA-041|Magnitude |X|X|Slot MAXMAG (faint limit) - star MAG >= 0.3|n/a |GS: Increased |
| | | | | | |risk of loss of |
| | | | | | |track of star |
+-------+------------------+-+-+-------------------------------------------+----+----------------+
Expand Down
12 changes: 2 additions & 10 deletions starcheck/src/lib/Ska/Starcheck/Obsid.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,9 +1480,7 @@ sub check_star_catalog {
push @orange_warn, sprintf "[%2d] Acq Off (padded) CCD by > 60 arcsec.\n",
$i;
}
elsif (($type =~ /BOT|ACQ/) and ($acq_edge_delta < 0)) {
push @{ $self->{fyi} }, sprintf "[%2d] Acq Off (padded) CCD\n", $i;
}


# Faint and bright limits ~ACA-009 ACA-010
if ($mag ne '---') {
Expand All @@ -1499,12 +1497,6 @@ sub check_star_catalog {
if ($mag < 5.2) {
push @warn, $acq_mag_warn;
}
elsif ($mag > $self->{mag_faint_red}) {
push @orange_warn, $acq_mag_warn;
}
elsif ($mag > $self->{mag_faint_yellow}) {
push @yellow_warn, $acq_mag_warn;
}
}
}

Expand Down Expand Up @@ -1541,7 +1533,7 @@ sub check_star_catalog {
}
}

if ($type =~ /BOT|GUI|ACQ/) {
if ($type =~ /BOT|GUI/) {
if (($maxmag =~ /---/) or ($mag =~ /---/)) {
push @warn, sprintf "[%2d] Magnitude. MAG or MAGMAX not defined \n",
$i;
Expand Down