Trim Perl dependencies by moving more to Python #348
Conversation
jeanconn
changed the title
|
My thought regarding the Dark Cal checker is that we can either run an old version of starcheck in a pinch or resurrect the Perl module if we go back to doing those activities. |
I'm good with cutting the dark cal checker. It is extremely unlikely we will go back to doing cals that way. |
|
Great! And yeah, I figured it was fine to cut but figured I'd talk it out in PR just like we have. |
| raise ValueError("Float run_start_time should be negative") | ||
| return ref_time.date | ||
| from starcheck.pcad_att_check import check_characteristics_date | ||
| from starcheck.utils import (_make_pcad_attitude_check_report, |
There was a problem hiding this comment.
Well, it was your idea and it was a good one! So much nicer to keep the Python in a separate file and just convenient for editing. I think some of the exception handling and wrappers still need simplification and improvement, but moving them into the separate file is a good start.
|
Terrific. What would you like to see for functional testing? And indeed I should have documented. Right now I've run on recent test loads and it runs in ska3 and makes output. Since making the PR, I've also run the old complete regression test set and they run without issue (functional component) and the output looks good with the only diffs being that all the dark cal checker output is correctly missing (regression tests pass). |
|
Sounds good. |
Description
Trim Perl dependencies by moving more to Python.
Specifically, this removes the rather heavy PDL dependency and also cuts the various time-related dependencies.
It also seemed time to move a bunch of Python into starcheck.utils to make it easier to call from multiple pieces of the Perl.
It also just removes the Dark Cal Checker.
Testing
Passes unit tests on MacOS, linux, Windows (at least one required)No unit tests