Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using proseco agasc file as default. #334

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Aug 6, 2019

Switch to using proseco agasc file as default.

@jeanconn
Copy link
Contributor Author

jeanconn commented Aug 6, 2019

I'll need to think a bit more on what we might want to do to show this is fine / safe .

@taldcroft
Copy link
Member

What's the driver?

@jeanconn
Copy link
Contributor Author

jeanconn commented Aug 6, 2019

Right now, we're using all three (agasc1p7.h5, miniagasc1p7.h5, and proseco_agasc_1p7.h5) in starcheck.

I'd like to cut down the dependencies from a maintenance perspective; and also I think in the agasc module aren't we building a Dec index for each of these as they are loaded? So I think it isn't super memory efficient either.

I just noticed it again when working standalone and I thought I had everything I wanted by my ska_sync didn't have the bigger agasc file.

But mostly I put the PR here because I thought it was a good idea for one minute and wanted to capture it. Didn't necessarily want to push this now.

@taldcroft
Copy link
Member

Sounds good. I see no problem in principle with using proseco_agasc everywhere (including in place of miniagasc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants