Update warning text to include CAUTION and CRITICAL #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
approved these changes
Jun 27, 2019
About the updated starcheck parser, I've forgotten again why we are not just using the JSON file. |
|
Because of limited resources? The starcheck_parser change is a few lines. Actually using the JSON file is a significant undertaking both to really put the things in it that we need (it is mostly just a mishmash now), put them in there in a useful structure, and then adapt all of the database code in mica.starcheck to work with that new structure. I'd like to do all that (!); just have not seen it as a priority. I've gotten as far as taking the action of "I should really look at that at some point". |
jeanconn
force-pushed
the
warn_formatting
branch
from
a6e13a0
to
fa58595
Compare
|
About the JSON, thanks for refreshing my memory. Your explanation makes sense. |
This was referenced Jul 17, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update warning text to include CAUTION and CRITICAL .
This also sorts the warnings and
Closes #315
This will need an updated starcheck_parser in mica.