Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to roll optimization #48

Merged
merged 6 commits into from
Feb 13, 2019
Merged

Improvements to roll optimization #48

merged 6 commits into from
Feb 13, 2019

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 12, 2019

Key changes:

  • Add useful info like roll range to get_roll_options output and HTML table
  • Fix bug rolling around science target for ERs

Closes #44
Fixes #43

Requires sot/proseco#269.

@taldcroft taldcroft added this to the 4.1 milestone Feb 12, 2019
@taldcroft
Copy link
Member Author

@jskrist - here are the members of the new roll options dict. A "roll interval" is a contiguous interval of roll within which a particular set of stars are all available for star selection.

'aca':  deepcopy(self), # ACAReviewTable object
'P2': P2,
'n_stars': n_stars,
'improvement': 0.0,
'roll': # roll of 'aca'
'roll_min': # minimum roll in this interval
'roll_max': # maximum roll in this interval
'add_ids': set(),  # Set of AGASC IDs that are **added** within roll interval
'drop_ids': set()}]  # Set of IDs that are **dropped** within roll interval

@taldcroft
Copy link
Member Author

@jskrist - This is ready. The main update from your perspective is the addition of roll, roll_min, roll_max, add_ids, drop_ids to the roll_options list of dict. I doubt you need to put the add_ids or drop_ids into your ORviewer reporting, that is more for ACA review and a bit for improving the roll optimization algorithm.

I'm merging this now so you can continue using master. You also need to use the recent master (2fe3c50) in proseco.

@taldcroft taldcroft merged commit 79e8115 into master Feb 13, 2019
@taldcroft taldcroft deleted the roll-meta branch February 13, 2019 20:24
@taldcroft
Copy link
Member Author

FYI here is what the new values look like as a table:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant