Refactor ruff into a base and package-specific #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
changed the title
|
I merged this without review since this doesn't impact code and mostly it's just me that cares about ruff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactosr the ruff config into a base file which goes in
skare3/templatesand an extension to handle package-specific updates to the rules.This uses the
ruff-base.tomlfile in sot/skare3#1269 and provides a demonstration of per-project extensions inruff.toml.Interface impacts
None
Testing
Unit tests
No code changes.
Functional tests
ruff .andruff formatboth succeed in the local repo.