Ruff changes #200
Merged
Ruff changes #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
reviewed
Nov 13, 2023
| if not isinstance(att, Quat): | ||
| att = Quat(att) | ||
| out.append(att) | ||
| out = [(att if isinstance(att, Quat) else Quat(att)) for att in atts] |
There was a problem hiding this comment.
A code change -- and totally fine.
jeanconn
reviewed
Nov 13, 2023
| @@ -546,7 +546,7 @@ def compare_intervs(intervs, exp_intervs): | |||
| assert len(intervs) == len(exp_intervs) | |||
| for interv, exp_interv in zip(intervs, exp_intervs): | |||
| assert interv.keys() == exp_interv.keys() | |||
| for key in interv.keys(): | |||
| for key in interv: | |||
There was a problem hiding this comment.
A code change -- also fine.
jeanconn
approved these changes
Nov 13, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This applies the ruff ruleset in sot/skare3#1202.
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.
JC: For functional testing -- I made a bunch of ugly whitespace edits to yoshi.py and confirmed that ruff as called by "pre-commit run" cleaned them up.