Package dashboard fixes #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierggt
force-pushed
the
packages-fixes
branch
from
34a54d0
to
d769460
Compare
…mit message, and removed use_pr_titles argument all over (titles are always used now)
javierggt
force-pushed
the
packages-fixes
branch
from
278724d
to
6190554
Compare
jeanconn
reviewed
Jan 9, 2024
| @@ -827,9 +849,6 @@ def _get_repository_info_v3( | |||
| :param since: int or str | |||
| the maximum number of releases to look back, or the release tag to look back to | |||
| (not inclusive). | |||
| :param use_pr_titles: bool | |||
There was a problem hiding this comment.
This isn't user-facing but maybe add to the description that this basically-unused feature is removed with this PR.
jeanconn
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for dashboard:
use_pr_titlesargument (which was neverFalseanyway)Fixes #105
Interface impacts
Testing
Unit tests
Functional tests
This is the version currently running in the dashboard. You can see starcheck 32 and agasc 161, which are squashed PRs.