Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for converting docstrings to numpydoc format #101

Merged
merged 6 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/black.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Lint

on: [push, pull_request]
on: [push]

jobs:
lint:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/flake8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Set up Python 3.8
- name: Set up Python 3.10
uses: actions/setup-python@v1
with:
python-version: 3.8
python-version: "3.10"
- name: Lint with flake8
run: |
pip install flake8
Expand Down
2 changes: 1 addition & 1 deletion skare3_tools/github/scripts/add_secrets.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def add_secrets(repository, secrets):

_driver_.find_element_by_id("secret_name").send_keys(secret)
value = secrets[secret]
if type(value) is dict:
if isinstance(value, dict):
value = json.dumps(value)
_driver_.find_element_by_id("secret_value").send_keys(value)

Expand Down
4 changes: 2 additions & 2 deletions skare3_tools/github/scripts/merge_pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def main():
kwargs["state"] = "open"
prs = repository.pull_requests(**kwargs)

if type(prs) is dict and not prs["response"]["ok"]:
if isinstance(prs, dict) and not prs["response"]["ok"]:
print(f'Failed getting requested PR: {prs["response"]["reason"]}')
sys.exit(1)

Expand All @@ -57,7 +57,7 @@ def main():
# sanity checks
sha = prs[0]["head"]["sha"]
if args.sha and sha != args.sha:
print(f"Requested sha does not match that of the PR")
print("Requested sha does not match that of the PR")
sys.exit(1)

# do the merge
Expand Down
Loading
Loading