-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ska3-matlab in bulk for 2019_210 #222
Conversation
What about annie? Baski expressed some mild interest. Eng_archive to 4.47.3? This is not a complete no-op for MATLAB, since truncating the archive has been advertised at the cheta sync tutorial. |
OK, so this is a draft and feedback is good. Yesterday you said don't bother to eng_archive 4.47.3; fine to add it. Also fine to add back in annie but we seem to have trouble cutting releases. |
Also in the running:
|
Sure. I would just sync things up. |
That was shortsighted on my part, both because there actually is a reason (that I just thought of), and more because the new policy is basically to not require a reason to sync up, but instead default to bringing all the MATLAB versions up to the very latest in flight. |
Do you mean not release any new packages for this? There are some tiny updates in open or merged prs that I thought might make sense to just get done. |
Well and 4.47.3 isn't in flight yet so policy fuzzy |
Specific examples would help out since this is news to me, but in general it seems fine. I would say to make the corresponding change(s) to ska3-flight/meta in master at the same time. I.e. make a separate PR to put in the new package to ska3-flight and milestone the PR with |
Specific examples include starcheck, Ska.eng_archive, annie, testr, and Ska.Shell with open and merged PRs that I tried to draw to your attention this morning via github. Honestly, it would be nice to get Quaternion, chandra_aca, and maude in too, but that seems a reach. |
Just for kicks I did a conda install of Ska.Shell to my Windows Ska3. It installs and imports, but tests, no so much:
Eventually if we have a Windows skare3 distribution then this would probably not be included for Windows. |
This does not surprise me. Also, is your vm 32 bit? |
64-bit Windows 10 |
OK, then should I be confused about "platform win32" in your pasted text? |
I've just installed this in a test / dev ska on fido and I'm not immediately understanding this error importing kadi. SKA is just set to /proj/sot/ska .
|
Perhaps. But it's definitely 64-bit, from the label that VirtualBox gives to the VM down to |
Ah. I wonder if he kadi problem is from find_attitude.web or some such in this test area. I conda removed find_attitude to check, but it looks like it is still registered with django (that seems like a bug). |
For today's ska3-matlab freeze I think removing find_attitude is OK. @taldcroft are we good to hand off this list of package updates and additions to Mark now? |
Looks good to me. For kicks I compared the ska3-matlab and ska3-flight distributions and got an expected result. I just wonder now if all the packages in ska3-flight3 should be similarly updated in master or even in this PR. (That doesn't affect handing off a version / package list to Mark).
|
I agree on also updating ska3-flight, but I don't think it necessarily needs to get done in this PR. Not going to miss that we want these updates, though I just opened a reminder issue. |
Though it looks like ska.shell went missing in my top matter, so I'll update that even if it doesn't apply to windows. |
b727e38
to
7121927
Compare
7121927
to
fb4a79e
Compare
This developed a conflict due the a find_attitude recipe in the branch. I just rebased that recipe away. ska3-matlab unchanged. |
Includes these pkg updates
adds pkgs