Update for new ska_helpers.chandra_models #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
jeanconn
approved these changes
May 31, 2023
|
Sorry about the unrelated tidy on imports. It's another evolution brought on by ruff rules and PEP8 which encourages using absolute imports unless they are very complicated. |
This was referenced Jun 1, 2023
Merged
This was referenced Jul 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates
ska_sunin response to theska_helpers.chandra_models.get_data()API change in sot/ska_helpers#33.Interface impacts
None apart from the
ROLL_TABLEgetting new metadata.Testing
Tested with sot/ska_helpers#33
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.