Fix bash support on catalina + modernize #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
force-pushed
the
fix-catalina
branch
from
43787b7
to
78532fd
Compare
This was referenced Jan 7, 2020
jeanconn
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting bash on MacOSX catalina one now gets a message that zsh is now the default interpreter shell. This breaks Ska.Shell completely, which I first noticed trying to run
ska_testr.This PR fixes this, but to be honest I don't 100% understand why Ska.Shell was ever working at all. The first thing it does (in master) when starting a shell is do an
spawn.expect('.+'). As noted in the documentation that is a useless anti-pattern. It could be that then_skip=1default was letting this work somewhat accidentally.https://github.com/sot/Ska.Shell/blob/6c345e29d4c3632bcf8d31b0acc3b183abf61187/Ska/Shell/shell.py#L99
This also does minor modernizing by dropping support for Python 2.7 and fixing some flake8 issues.
Testing
Passes unit tests on: