Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading chandra_models data #32

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 28, 2023

Description

This is in support of sot/chandra_models#104 and the general effort to move more operations data or model files into chandra_models.

It is based heavily off of similar code in xija.get_xija_model.

While building the sphinx docs I saw a bunch of errors in ska3-prime and so I just fixed them here.

Interface impacts

Adds a new module.

Testing

Unit tests

  • Mac (New unit tests)
  • TO DO: Run unit testing run on Windows.

Independent check of unit tests by Jean

  • Linux

Functional tests

None

@jeanconn
Copy link
Contributor

jeanconn commented Mar 1, 2023

I think the most useful behavior for me would be if the git mechanism in interacting with the chandra_models repo would confirm that the repo was checked out at or past the most recent tag on github, and then just gave a warning if the repo is dirty or different.

@jeanconn
Copy link
Contributor

jeanconn commented Mar 1, 2023

If I have a work around of just tagging in chandra_models to do chandra_models testing (noted in sot/ska_sun#27 (comment)) these changes in ska_helpers that basically do what was done in xija make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants