Add includes_for_obsid helper function #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeanconn - are you planning to review this then? |
|
No, I was actively reviewing this item 😄 |
jeanconn
approved these changes
Nov 8, 2019
jeanconn
reviewed
Nov 8, 2019
| def includes_for_obsid(obsid): | ||
| """ | ||
| Return a dict with the include_ids_acq, include_halfws_acq and include_ids_guide | ||
| lists for the as-run flight catalog of ``obsid``. Useful for forcing catalog. |
There was a problem hiding this comment.
I note that get_starcheck_catalog has both as-run catalogs and has ingested latest-version catalogs for obsids that haven't actually run yet. But that does not apply to this PR.
jeanconn
reviewed
Nov 8, 2019
|
|
||
| ok = np.in1d(cat['type'], ('ACQ', 'BOT')) | ||
| out['include_ids_acq'] = cat['id'][ok].tolist() | ||
| out['include_halfws_acq'] = cat['halfw'][ok].tolist() |
There was a problem hiding this comment.
This looks good as I don't see any way the ids and the halfwidths can end up with mismatched indexes.
jeanconn
reviewed
Nov 8, 2019
| """ | ||
| from mica.starcheck import get_starcheck_catalog | ||
|
|
||
| obs = get_starcheck_catalog(obsid) |
There was a problem hiding this comment.
Could use get_starcat here but get_starcheck_catalog is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309. (Supercedes).