PEP8, flake8 and sphinx RST fixes #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
changed the title
javierggt
approved these changes
Sep 19, 2019
| @@ -9,7 +9,6 @@ | |||
| import numpy as np | |||
| from scipy import ndimage, stats | |||
| from scipy.interpolate import interp1d | |||
| from astropy.table import Table | |||
There was a problem hiding this comment.
I am assuming that this was imported and not used.
There was a problem hiding this comment.
I did run tests, but it isn't a bad idea as reviewer to just independently check out the repo in this branch and run python setup.py test or pytest proseco. Then you will know for sure about the import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of the end of PEP8 and flake8 violations in Ska3 code. I'm using the following for my
~/.config/pycodestylefile (which also controlsautopep8):I've applied for GitHub actions for the
sotorg. When we get accepted then we'll start enforcingflake8compliance for merge. E.g. https://github.com/actions/starter-workflows/blob/master/ci/python-package.yml.