Implement capping of catalog MAXMAG to 11.2 mag #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussions in emails ("maxmag" near June 7, 2019), the MAXMAG parameter in commanded star catalogs should be capped at 11.2 mag. This makes that change in proseco catalogs.
This PR does not implement capping of the
maxmag
parameter found in the acq star selection code. That value ofmaxmag
is actually a different quantity, defined as 1-sigma above the star mag. In practice that will rarely be above 11.2 for selected stars, but in any case I would rather leave the acq selection algorithm unchanged so this PR does not introduce any change in star selection.cc: @mbaski @jskrist