Set stars for plot() if needed #290
Conversation
| @@ -691,6 +691,8 @@ def plot(self, ax=None, **kwargs): | |||
| :param kwargs: other keyword args for plot_stars | |||
| """ | |||
| kwargs.setdefault('catalog', self.get_catalog_for_plot()) | |||
| if self.stars is None: | |||
There was a problem hiding this comment.
It looks like set_stars has its own logic to try to decide where to get the stars, but I think it is relatively low-impact to just have a go at getting something if we reach this point and have no stars.
Unless this should be done from BaseCatalogTable or from chandra_aca.plot itself...
|
I wanted to completely re-work the stars attribute handling in a fashion similar to dark, but it turns out to be slightly trickier and I punted. Did you want this for 4.4? |
|
But to be clear getting the |
|
Not critical for 4.4, I just wasn't sure if there was any reason not to throw something like this in for the time being. But given that the use case is mostly so I can make debugging plots, there's no rush now that I'm comfortable with just doing on a pickle-loaded catalog as needed. |
Set stars for plot() if needed