Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign a type to get_guide_catalog cats to plot #286

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Conversation

jeanconn
Copy link
Contributor

Assign a type to get_guide_catalog cats to plot.

Closes #260

@jeanconn
Copy link
Contributor Author

If we are sparking some joy, can I have this bug fix to plot guide catalogs? I have not added a test.

@taldcroft
Copy link
Member

Just need a functional test (you doing something in ipython or whatever) to verify this is working, and passing unit tests.

@jeanconn
Copy link
Contributor Author

Right, I had basically done:

fido: ipython
Python 3.6.2 |Continuum Analytics, Inc.| (default, Jul 20 2017, 13:51:32) 
Type 'copyright', 'credits' or 'license' for more information
IPython 6.1.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from proseco.acq import get_acq_catalog

In [2]: from proseco.guide import get_guide_catalog

In [3]: from proseco import get_aca_catalog

In [4]: %pylab
Using matplotlib backend: TkAgg
Populating the interactive namespace from numpy and matplotlib

In [5]: acqs = get_acq_catalog(20603)

In [6]: acqs.plot()
Out[6]: <matplotlib.figure.Figure at 0x7f93c958da58>

In [7]: guides = get_guide_catalog(22058)

In [8]: guides.plot()
Out[8]: <matplotlib.figure.Figure at 0x7f93c8b8d400>

In [9]: cat = get_aca_catalog(21872)

In [10]: cat.plot()
Out[10]: <matplotlib.figure.Figure at 0x7f93b4b8c470>

And confirmed plots were made. Unit tests (which also have some plot calls) were still passing.

@taldcroft taldcroft added this to the 4.4 milestone Feb 21, 2019
@taldcroft taldcroft merged commit bc00272 into master Feb 21, 2019
@taldcroft taldcroft deleted the plot_guide_cats branch February 21, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants