Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acq report format a bit, tidy code, change raise_exc default #285

Merged
merged 3 commits into from
Feb 21, 2019

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 21, 2019

Changing the default of raise_exc is the big API change here.

@taldcroft taldcroft added this to the 4.4 milestone Feb 21, 2019
@taldcroft taldcroft changed the title Update acq report format a bit and tidy code Update acq report format a bit, tidy code, change raise_exc default Feb 21, 2019
@taldcroft
Copy link
Member Author

Hmm, I don't see a way to change the branch this merges into. Gotta run, but I guess will make a new PR for merge to master?

@jeanconn
Copy link
Contributor

For me, I can change target branches from the edit (that looks like it is for the subject, but gives a drop down for target branch). Is that what you meant?

@taldcroft
Copy link
Member Author

But of course!

@taldcroft taldcroft changed the base branch from no-weak to master February 21, 2019 15:20
@jskrist jskrist mentioned this pull request Feb 21, 2019
@taldcroft taldcroft merged commit 8721ee3 into master Feb 21, 2019
@taldcroft taldcroft deleted the tidy-spark-joy branch February 21, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants