Always cast 'att' attribute into Quat object #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
approved these changes
Feb 20, 2019
| class QuatMetaAttribute(MetaAttribute): | ||
| def __set__(self, instance, value): | ||
| if not isinstance(value, Quat): | ||
| value = Quat(value) |
There was a problem hiding this comment.
This seems fine. I've sometimes run into issues with the not-quite-normalized Quat, but hopefully anything that reaches this point will be fine.
There was a problem hiding this comment.
Default handling of a not-quite-normalized Quat should be handled upstream by Quat. Maybe auto-fix if within some threshold? Is there something like that already?
There was a problem hiding this comment.
Right now there's just a good error message. For proseco I had the MATLAB side explicitly normalize to avoid the possibility of it being a problem with these attitudes (relying on later checking to catch any problem).
taldcroft
added a commit
that referenced
this pull request
Feb 20, 2019
taldcroft
added a commit
that referenced
this pull request
Feb 20, 2019
Fix guide and acq report templates after #281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving the
att(attitude) attribute as whatever the user supplied instead of casting to Quat makes life difficult for downstream code. This fixes that and with this in place one can be sure thataca.attis aQuat.This passes tests. Sparkles passes tests (except for the known fail).