Move dark attribute from MetaAttribute to property #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point, are we provisionally done with proseco 4.4? |
|
Has #259 been addressed? In either case I'm fine with cutting 4.4 now. The only question is about remaining issues in sparkles that might need an upstream proseco fix. |
|
Right, I wasn't sure if we'd want to recut at 4.4 for anything else with a fix or just call them patches. Regarding #259, I'd say it has not really been addressed but that the changes we have merged seem reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies code, and makes the "dark" attribute a reliably-available property.
It also results in the AcqTable object using the "correct" dark current map based on
t_ccd_acq.