Fix tests related to guide_count #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
commented
Feb 14, 2019
| @@ -189,7 +189,7 @@ def test_pickle(): | |||
| """ | |||
| stars = StarsTable.empty() | |||
| stars.add_fake_constellation(mag=10.0, n_stars=5) | |||
| aca = get_aca_catalog(stars=stars, raise_exc=True, **STD_INFO) | |||
| aca = get_aca_catalog(stars=stars, dark=DARK40, raise_exc=True, **STD_INFO) | |||
There was a problem hiding this comment.
This was always only selecting 4 stars and just squeaking by with guide count of 4.0. That was not the intent of this test
There was a problem hiding this comment.
Gotcha. And yes, those 10.0 mag stars can be tricky on an average dark map. Looks like a reasonable fix.
There was a problem hiding this comment.
For the record can you punch the approve?
jeanconn
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires sot/chandra_aca#72