Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove really bright stars from early stages and modify offset thresholds #254

Merged
merged 7 commits into from
Feb 19, 2019
Merged

Remove really bright stars from early stages and modify offset thresholds #254

merged 7 commits into from
Feb 19, 2019

Commits on Feb 17, 2019

  1. Remove really bright stars from early stages

    @jeanconn
    jeanconn committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    5a1a779 View commit details
    Browse the repository at this point in the history

  2. Add more margin to the code for bright star selection 

    In the "select stars for this stage by mag" code, these changes
1). Set a lower bound of 0.1 mags on the effective mag error of
stars brighter than 7.0 mag
2). Set a lower bound of 1 on the multiplier used with the effective
mag error.
3). Explicitly exclude stars that are within 2 sigma of 5.8
    @jeanconn
    jeanconn committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    c51a360 View commit details
    Browse the repository at this point in the history

  3. Set lower bound on mag_err to 0.5 for color1=0.7 stars in bounds check

    @jeanconn
    jeanconn committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    dad9fc9 View commit details
    Browse the repository at this point in the history

  4. Fix long line

    @jeanconn
    jeanconn committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    c60218b View commit details
    Browse the repository at this point in the history

  5. Leave the faint end alone for now

    @jeanconn
    jeanconn committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    9b51491 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. Add a 6th stage to bring in guide stars as bright as 5.8 mag

    @jeanconn
    jeanconn committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    f578d44 View commit details
    Browse the repository at this point in the history

  2. Reduce offset thresholds in stages 4 and 5

    @jeanconn
    jeanconn committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    1f2196b View commit details
    Browse the repository at this point in the history