Add 3 pixels to edge margin for guide star selection (4.3.x patch) #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
reviewed
Jan 25, 2019
|
The only thing driving it (here) is a copy of the test that was already there. (whether or not I unconsciously find the negative more noticeable on |
taldcroft
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3 pixels to edge margin for guide star selection (4.3.x patch)
This PR makes a new characteristics value proseco.characteristics_guide.CCD['guide_extra_pad'] that is set to 3 pixels. This is used in guide star selection as part of the initial filter on stars so these stars that do not have at least these 3 extra pixels margin from the dither padded + window padded + (row/col) padded edge will not make the initial cut of candidates.