Make AcqProbs ref to parent acqs be a weakref #227
Conversation
| # contextual hack. | ||
| if self.cand_acqs is not None: | ||
| for probs in self.cand_acqs['probs']: | ||
| probs.acqs = weakref.ref(self) |
There was a problem hiding this comment.
This looks reasonable to me, but I'm not as clear about how we get to this point in the code. With that in mind does this need any new tests besides the two assert statements added in test_catalog?
There was a problem hiding this comment.
This is basically the unpickling post-processing code, so gets called when an AcqTable is unpickled. The existing tests (even without the two new asserts) will give an exception without this code. I've added a comment in the test code to explain why the asserts there are "strong" tests of this new functionality, agreed it wasn't obvious just from the asserts.
|
These updates work on Windows and appear to resolve the memory leak (memory doesn't keep increasing each time a DOT is generated from ORViewer). The unit tests pass "105 passed in 55.53 seconds" on Windows and the DOT and associated files generated with this updated version of proseco using the dbtest/11706/DEC2418_11706.mat workspace are exactly the same as before the update (except for timestamps, of course). |
Basically the same as #226, but applied to the 4.3.x branch.
The refactoring in master made it not possible to cherry pick the commits so I just applied the diffs from #226 by hand (in a "curated" way to make it right for 4.3.x).
Memory leak fix. The plot below shows memory usage (blue) for selecting 300 full catalogs on Mac:
Testing:
index.htmlfrom 4.3.1.