Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More guide test updates #218

Merged
merged 6 commits into from
Jan 9, 2019
Merged

More guide test updates #218

merged 6 commits into from
Jan 9, 2019

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Dec 28, 2018

More guide test updates including docstring updates and a new synthetic common column test.

Closes #203

@taldcroft
Copy link
Member

Rebased after #221.

@taldcroft
Copy link
Member

taldcroft commented Jan 2, 2019

@jeanconn - added 7f28dce. This might fall into the category of functional validation and need more investigation. I'm not sure I understand the results there which are almost independent of the delta mag, and I definitely don't think a 15th mag star (mag0=8 and dmag=7) should ever spoil anything. That corresponds to 70 e-/sec.

@jeanconn
Copy link
Contributor Author

jeanconn commented Jan 2, 2019

I didn't think the 15th mag star about which you speak would be in the proseco AGASC unless it had large mag error (which is used in check_mag_spoilers).

@taldcroft
Copy link
Member

Proseco AGASC has every star in the AGASC that is near a candidate guide or acq star with ASPQ1 > 0. Here is the MAG_ACA distribution.

image

@jeanconn
Copy link
Contributor Author

jeanconn commented Jan 2, 2019

Ah. OK. So probably should have had some useful demonstrable grid of spoiler tests before transitioning to the proseco AGASC, as functionally that means the available spoilers changed during development. But overall the population of concern is still small. I think this still falls more into parameter optimization, enhancement, and review as part of #220 . At worst the current code excludes candidates that are not really spoiled "enough".

@taldcroft taldcroft merged commit 24ad845 into master Jan 9, 2019
@taldcroft taldcroft deleted the more_test_updates branch January 9, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants