-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More guide test updates #218
Conversation
d7626e3
to
ef2ae51
Compare
ec69dd2
to
3bb2c7c
Compare
Rebased after #221. |
@jeanconn - added 7f28dce. This might fall into the category of functional validation and need more investigation. I'm not sure I understand the results there which are almost independent of the delta mag, and I definitely don't think a 15th mag star (mag0=8 and dmag=7) should ever spoil anything. That corresponds to 70 e-/sec. |
I didn't think the 15th mag star about which you speak would be in the proseco AGASC unless it had large mag error (which is used in check_mag_spoilers). |
Ah. OK. So probably should have had some useful demonstrable grid of spoiler tests before transitioning to the proseco AGASC, as functionally that means the available spoilers changed during development. But overall the population of concern is still small. I think this still falls more into parameter optimization, enhancement, and review as part of #220 . At worst the current code excludes candidates that are not really spoiled "enough". |
a8dca07
to
a19dd66
Compare
More guide test updates including docstring updates and a new synthetic common column test.
Closes #203