Improve stars handling and put FOV filtering into set_stars() #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver here is having the full list of stars (via radial selection from AGASC) available to allow roll optimization. Now the
ACATable
catalog has the full list and acqs, fids, and guides have the FOV-filtered list (where FOV means within 40 pixels of the CCD edge).The key code change is moving the FOV-filtering from
StarsTable.from_stars()
intoACACatalogTable.set_stars()
, and adding a new arg to the latter to turn-off FOV-filtering if required.