Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stars handling and put FOV filtering into set_stars() #214

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

taldcroft
Copy link
Member

The driver here is having the full list of stars (via radial selection from AGASC) available to allow roll optimization. Now the ACATable catalog has the full list and acqs, fids, and guides have the FOV-filtered list (where FOV means within 40 pixels of the CCD edge).

The key code change is moving the FOV-filtering from StarsTable.from_stars() into ACACatalogTable.set_stars(), and adding a new arg to the latter to turn-off FOV-filtering if required.

@taldcroft taldcroft merged commit 57a31be into master Dec 27, 2018
@taldcroft taldcroft deleted the stars branch December 27, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant