Refactor cat table #213
Merged
Refactor cat table #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make StarsTable inherit from a much smaller base class than the original ACACatalogTable. The latter has tons of stuff that does not apply to StarsTable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing really controversial here, just got annoyed that
StarsTablewas inherited fromACACatalogTableand got all these methods and such that really don't apply.There is a small functional diff in that
StarsTablenow has its ownattattribute that actually gets set and used. This makes it possible to have aplot()method which I have added here. It also makes it possible to check the attitude infrom_stars(), and this led to the digression of obsid 2365 since that failed the attitude check originally.